added queries daily rewards and fees #278
Conversation
|
@data-cowwboy Can you try to fix the linting complaints? If not, we should do something about it as I don't think it makes sense to have these checks but then ignore them |
| @@ -0,0 +1,82 @@ | |||
| -- This query provides data related to rewards/payouts on a per auction level | |||
There was a problem hiding this comment.
Is there a reason why we essentially fork the auction_data query instead of simply invoking it?
There was a problem hiding this comment.
The original query didnt have block date column. The other way will be to just use it and then join with blocks table outside in the main query. I did this way as i exploring the logic first, and then thought the shorter the main query the better.
But makes sense, i will incorporate that.
| @@ -0,0 +1,45 @@ | |||
| -- This query returns slippage per solver and per transaction over a period of time-- evaluated in both usd and the native token of the chain. -- -- Parameters: -- {{start_time}} - the timestamp for which the analysis should start (inclusively) -- {{end_time}} - the timestamp for which the analysis should end (exclusively) -- {{blockchain}} - network to run the analysis on -- {{slippage_table_name}} - slippage_per_transaction for aggregated values per transaction; -- slippage_per_solver for aggregated values per transaction -- -- The columns of slippage_per_transaction are -- - block_time: time of settlement transaction -- - tx_hash: settlement transaction hash -- - solver_address: address of the solver executing the settlement -- - slippage_usd: USD value of slippage -- - slippage_wei: value of slippage in atoms of native token -- - imbalance_usd: USD value of total buffer imbalance -- - protocol_fee_usd: USD value of protocol fees -- - network_fee_usd: USD value of network fees -- -- The columns of daily_slippage_per_solver are -- - solver_address: address of the solver executing the settlement -- - slippage_usd: USD value of slippage -- - slippage_wei: value of slippage in atoms of native token -- -- Results of the query are filtered to not include batches from excluded_batches. -- Batches are also excluded if there is a non-zero imbalance and no value (in native atoms). | |||
There was a problem hiding this comment.
Same here, why fork this query? This will make it harder to maintain all these
harisang
left a comment
harisang
left a comment
There was a problem hiding this comment.
Left some comments and questions
|
@data-cowwboy Could you add a proper description to the PR as well? |
This PR adds dune query to check Solver rewards and Fees on daily level.